Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubnetInfo and shared validator data affecting aggregation publish #1286

Open
rodrigo-o opened this issue Sep 6, 2024 · 0 comments
Open
Labels
bug Something isn't working P2 This is a nice to have. Improves usability of the app or the libraries, but it's not urgent.

Comments

@rodrigo-o
Copy link
Collaborator

After #1218 Subnet information is collected in a shared way by all validators, this affects the current SubnetInfo as well as the about to be introduced SyncSubnetInfo in #1284. In setups with lots of validators on other nodes or low amount of validators in ours this is not seen, but when more than one validator has aggregation duties on the same slot, the first one who stops collecting messages is the one who produce the aggregation first.

This is something that happens easily in kurtosis due to the low amount of aggregators and how easy is to find multiple aggregators for the same slot, but shouldn't be common on testnets or mainnet (Please correct me if I'm missing something here) so this is low priority.

Here is a log showing the issue seen while working on #1284:

2024-09-05 18:58:02 INFO 21:58:02.003 [Validator] 8 published aggregate slot=2
2024-09-05 18:58:02 ERROR 21:58:02.004 [Validator] 5 Failed to stop collecting attestations. Reason: subnet not joined 
2024-09-05 18:58:02 ERROR 21:58:02.004 [Validator] 21 Failed to stop collecting attestations. Reason: subnet not joined 
2024-09-05 18:58:02 ERROR 21:58:02.005 [Validator] 22 Failed to stop collecting attestations. Reason: subnet not joined 
2024-09-05 18:58:02 INFO 21:58:02.006 [Validator] 44 published aggregate slot=2
2024-09-05 18:58:02 ERROR 21:58:02.007 [Validator] 12 Failed to stop collecting attestations. Reason: subnet not joined 
2024-09-05 18:58:02 ERROR 21:58:02.007 [Validator] 14 Failed to stop collecting attestations. Reason: subnet not joined 
2024-09-05 18:58:02 ERROR 21:58:02.007 [Validator] 30 Failed to stop collecting attestations. Reason: subnet not joined 
2024-09-05 18:58:02 INFO 21:58:02.008 [Validator] 44 publishing sync committee aggregate slot=2
2024-09-05 18:58:02 INFO 21:58:02.009 [Validator] 44 published sync committee aggregate slot=2
2024-09-05 18:58:02 INFO 21:58:02.010 [Validator] 29 publishing sync committee aggregate slot=2
2024-09-05 18:58:02 INFO 21:58:02.011 [Validator] 29 published sync committee aggregate slot=2
2024-09-05 18:58:02 INFO 21:58:02.011 [Validator] 61 publishing sync committee aggregate slot=2
2024-09-05 18:58:02 INFO 21:58:02.012 [Validator] 61 published sync committee aggregate slot=2
2024-09-05 18:58:02 ERROR 21:58:02.013 [Validator] 30 Failed to stop collecting sync committee messages. Reason: subnet not joined 
2024-09-05 18:58:02 ERROR 21:58:02.013 [Validator] 45 Failed to stop collecting sync committee messages. Reason: subnet not joined 
2024-09-05 18:58:02 ERROR 21:58:02.014 [Validator] 48 Failed to stop collecting sync committee messages. Reason: subnet not joined 
2024-09-05 18:58:02 ERROR 21:58:02.014 [Validator] 57 Failed to stop collecting sync committee messages. Reason: subnet not joined 
2024-09-05 18:58:02 ERROR 21:58:02.015 [Validator] 26 Failed to stop collecting sync committee messages. Reason: subnet not joined 
2024-09-05 18:58:02 ERROR 21:58:02.015 [Validator] 63 Failed to stop collecting sync committee messages. Reason: subnet not joined 
2024-09-05 18:58:02 ERROR 21:58:02.015 [Validator] 46 Failed to stop collecting sync committee messages. Reason: subnet not joined 
@rodrigo-o rodrigo-o added bug Something isn't working P2 This is a nice to have. Improves usability of the app or the libraries, but it's not urgent. labels Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 This is a nice to have. Improves usability of the app or the libraries, but it's not urgent.
Projects
Status: No status
Development

No branches or pull requests

1 participant