Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an Http client to the native erc20 fetcher #187

Closed
jrchatruc opened this issue Feb 23, 2024 · 1 comment
Closed

Add an Http client to the native erc20 fetcher #187

jrchatruc opened this issue Feb 23, 2024 · 1 comment
Assignees
@jrchatruc
Labels
erc20-base-token

Comments

@jrchatruc
Copy link
Member

🌟 Feature Request

The NativeErc20Fetcher is currently creating a new http client each time it makes a request. It should instead keep one in a field that's initialized on startup and then use that each time.

Reference: matter-labs#996 (comment)
@jrchatruc jrchatruc mentioned this issue Feb 26, 2024
Merged
6 tasks
@jrchatruc jrchatruc self-assigned this Feb 27, 2024
@juan518munoz
Copy link

Closed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrchatruc jrchatruc

Labels
erc20-base-token
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrchatruc @juan518munoz