Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write a report about tests running against the era-test-node #93

Open
mationorato opened this issue Aug 2, 2023 · 2 comments
Open

Write a report about tests running against the era-test-node #93

mationorato opened this issue Aug 2, 2023 · 2 comments
Assignees

Comments

@mationorato
Copy link
Collaborator

mationorato commented Aug 2, 2023

Write a report about the testing status against this era-test-node PR.

We should have some clarity on which features are working, which are not and why.

If we found that some failing test is related to a missing RPC method, we add that endpoint here

@jpcenteno
Copy link
Contributor

I wrote a notion document detailing and classifying each of the failing tests

The failing tests can be grouped into these major categories:

  • Tests that require a different rich wallet parameter to be passed.
    • This can be easily solved, but we should discuss how to parameterize our test suite first.
  • Tests that require interaction with the layer 1, which is currently unsupported by the in-memory node.
  • Tests with discrepancies in the expected JSON-RPC response.
  • Tests which fail due to unimplemented JSON-RPC methods.

@jpcenteno
Copy link
Contributor

The ticket also required this:

If we found that some failing test is related to a missing RPC method, we add that endpoint matter-labs/era-test-node#21

But that PR has already been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants