Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS styles can leak into the Lamdera Live overlay #37

Open
edkelly303 opened this issue Jan 13, 2025 · 1 comment
Open

CSS styles can leak into the Lamdera Live overlay #37

edkelly303 opened this issue Jan 13, 2025 · 1 comment

Comments

@edkelly303
Copy link
Collaborator

edkelly303 commented Jan 13, 2025

Quick Summary:
The <a> element in the overlay that links to the Lamdera docs can inherit styles from the app's CSS, as in this screenshot:

image

SSCCE

Here's the CSS that causes this, which is in public/styles.css in my repo:

a:not(nav *) {
    border-color: var(--acnt-07-bd);
    background-color: var(--acnt-03-el);
    border-radius: 5px;
    border-width: 2px;
    border-style: solid;
    text-decoration: none;
    padding: 5px;
}
  • Elm: 19.1 / Lamdera 1.3.2
  • Browser: Firefox
  • Operating System: Nixos

Additional Details

N/A

@lishaduck
Copy link

Declarative Shadow DOM is baseline now, so fixing this should be as simple as replacing the div with a <template shadowrootmode="open">.
I couldn't find where it's created, or else I'd PR it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants