Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create next milestones after a release is prepared #26

Closed
Ocramius opened this issue Aug 2, 2020 · 4 comments · Fixed by #37
Closed

Create next milestones after a release is prepared #26

Ocramius opened this issue Aug 2, 2020 · 4 comments · Fixed by #37

Comments

@Ocramius
Copy link
Member

Ocramius commented Aug 2, 2020

Feature Request

See doctrine/automatic-releases#26

After a release is done, we want to implicitly generate new milestones.

Given following milestones:
  | name |
  | 1.0.0 |
When milestone 1.0.0 is closed
Then following milestones should exist:
  | name |
  | 1.0.1 |
  | 1.1.0 |
  | 2.0.0 |

This should probably be done as a new command to be added to the automatic-release workflow example.

Note: the command must gracefully ignore pre-existing milestones with same names, and duplicate milestone names must never be possible!

Q A
New Feature yes
RFC no
BC Break no
@geerteltink
Copy link
Member

I was wondering, should the 2.0.0 milestone be created even when it's not needed yet? How about we check if we check to a new milestone created event and create a release branch from the current default branch for it (if it doesn't exist). This way we don't need to sync everything to a possible 2.0.x branch if there is no need for it.

@Ocramius
Copy link
Member Author

Ocramius commented Aug 4, 2020

IMO it doesn't hurt to always create the next major milestone: sync-up is a relatively painless process, and the next major branch can be deleted if needed

@geerteltink
Copy link
Member

Which one would be the default branch if 1.2.x and 2.0.x are created? 1.2.x?

@Ocramius
Copy link
Member Author

Ocramius commented Aug 5, 2020

This is only about creating the new milestone, not the branch.

The tool does not implicitly create a new major branch, or else it would always set it as the default branch too (messy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants