Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#8 restore laminas/automatic-releases CLI application version parsing #9

Open
Ocramius opened this issue Jul 19, 2020 · 2 comments
Open

#8 restore laminas/automatic-releases CLI application version parsing #9

Ocramius opened this issue Jul 19, 2020 · 2 comments
Assignees
@Ocramius
Labels
Enhancement

Comments

@Ocramius
Copy link
Member

In #8 and #10, we disable version parsing by removing .git from the Dockerfile: we will need to re-enable it again, so that the correct application version can be rendered in case of bugs:

automatic-releases/bin/console.php

Line 68 in ea00621

$application = new Application(Versions::ROOT_PACKAGE_NAME, Versions::getVersion('laminas/automatic-releases'));

@Ocramius Ocramius added this to the 1.1.0 milestone Jul 19, 2020
@Ocramius Ocramius self-assigned this Jul 19, 2020
Ocramius added a commit that referenced this issue Jul 19, 2020
@Ocramius
#8 #9 disable adding .git during Dockerfile steps
ef5e910 
This fixes #8, but skips version rendering in our CLI: that's
an acceptable tradeoff, for now: we'll need to fix this later,
when we work on #9 (or eventually consider dropping this code
entirely).
@Ocramius Ocramius mentioned this issue Jul 19, 2020
Merged
Ocramius added a commit that referenced this issue Jul 19, 2020
@Ocramius
Merge pull request #10 from laminas/fix/#8-remove-git-dir-from-being-…
0fc020d 
…added-to-docker-container

#8 #9 disable adding `.git` during `Dockerfile` steps
@Ocramius Ocramius changed the title #8 restore version parsing #8 restore laminas/automatic-releases CLI application version parsing Jul 19, 2020
@Ocramius Ocramius modified the milestones: 1.1.0, 1.2.0, 1.3.0 Aug 6, 2020
@weierophinney weierophinney modified the milestones: 1.3.0, 1.4.0 Aug 26, 2020
@weierophinney
Copy link
Member

How do you suggest making this happen? Cloning the repo into /app within Dockerfile? Or a release action that sets the release version in a placeholder?

@Ocramius Ocramius removed this from the 1.4.0 milestone Aug 31, 2020
@Ocramius
Copy link
Member Author

I think GitHub actions contain an implicit env var with the action name+version: to be checked 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weierophinney @Ocramius