Skip to content

Commit

Permalink
Checklinks.
Browse files Browse the repository at this point in the history
  • Loading branch information
reynoldsalec committed Feb 2, 2024
1 parent 530c856 commit 8ffbbc8
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 22 deletions.
22 changes: 5 additions & 17 deletions docs/config.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ services:
## Choosing a server (or not)
By default, `php` services will be served by the default version of our [apache](https://docs.lando.dev/core/v3/apache.html) service but you can switch this to either `nginx` or `cli`.
By default, `php` services will be served by the default version of our [apache](https://docs.lando.dev/apache/) service but you can switch this to either `nginx` or `cli`.

Like with `apache`, `nginx` will use the the default version of our [nginx](https://docs.lando.dev/core/v3/nginx.html) service while `cli` will just spin up a `php` container without a web server. The latter is useful if you just want to work on a CLI utility or lock down what version `composer` runs with.
Like with `apache`, `nginx` will use the the default version of our [nginx](https://docs.lando.dev/nginx/) service while `cli` will just spin up a `php` container without a web server. The latter is useful if you just want to work on a CLI utility or lock down what version `composer` runs with.

#### With Apache (default)

Expand Down Expand Up @@ -133,21 +133,9 @@ services:

While Lando will handle the server side configuration for you, there is often a considerable amount of pain lurking in the client side configuration. To that end, some helpful info about a few popular clients is shown below:

**ATOM**
**PHPStorm**

An example config for [ATOM's](https://atom.io/) [`php-debug`](https://github.com/gwomacks/php-debug) plugin is shown below:

```json
"php-debug":
{
ServerPort: 9000
PathMaps: [
"/app/www;/Users/pirog/Desktop/work/lando/examples/lando/www"
]
}
```

The first part of a pathmap will be the location of your code in the container. Generally, this should be `/app`. Also note that if your app is in a nested docroot, you will need to append that to the paths. The example above uses an app with a nested webroot called `www`.
[Lando + PhpStorm + Xdebug](https://docs.lando.dev/guides/lando-phpstorm.html)

**VSCODE**

Expand Down Expand Up @@ -236,7 +224,7 @@ You may need to override our [default php config](https://github.com/lando/php/t

If you do this, you must use files that exist inside your application and express them relative to your project root as shown below:

Note that the default files may change based on how you set both `ssl` and `via`. Also note that the `vhosts` and `server` config will be either for `apache` or `nginx` depending on how you set `via`. We *highly recommend* you check out both the [apache](https://docs.lando.dev/apache) and [nginx](https://docs.lando.dev/nginx) if you plan to use a custom `vhosts` or `server` config.
Note that the default files may change based on how you set both `ssl` and `via`. Also note that the `vhosts` and `server` config will be either for `apache` or `nginx` depending on how you set `via`. We *highly recommend* you check out both the [apache](https://docs.lando.dev/apache/) and [nginx](https://docs.lando.dev/nginx/) if you plan to use a custom `vhosts` or `server` config.

If you set `via: cli` then, as you might suspect, `vhosts` and/or `server` is not going to do anything.

Expand Down
4 changes: 2 additions & 2 deletions docs/development.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: Learn how to develop and contribute to the Lando Php service

# Development

This guide contains information to help onboard developers to work on the [php](https://php.microsoft.com/en-us/) integration, hereafter referred to as *the plugin*.
This guide contains information to help onboard developers to work on the [php](https://www.php.net/) integration, hereafter referred to as *the plugin*.

## Requirements

Expand Down Expand Up @@ -162,4 +162,4 @@ npm install @lando/php@edge

## Contribution

If you want to contribute code then just follow [this flow](https://docs.github.com/en/get-started/using-github/github-flow).
If you want to contribute code then just follow [this flow](https://docs.github.com/en/get-started/using-github/github-flow).
2 changes: 1 addition & 1 deletion docs/extensions.md
Original file line number Diff line number Diff line change
Expand Up @@ -88,5 +88,5 @@ services:
- docker-php-ext-enable memcached
```
Note the usage of `docker-php-ext-enable`. Our images extend the [official Docker php images](https://hub.docker.com/r/library/php) which ship with a bunch of [helpful utility scripts](https://github.com/docker-library/php) to manage php extensions.
Note the usage of `docker-php-ext-enable`. Our images extend the [official Docker php images](https://hub.docker.com/_/php) which ship with a bunch of [helpful utility scripts](https://github.com/docker-library/php) to manage php extensions.

4 changes: 2 additions & 2 deletions docs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ next: ./config.html

# PHP

[PHP](http://php.net/) is a popular scripting language that is especially suited for web development. It is often served by either [apache](https://docs.lando.dev/core/v3/apache.html) or [nginx](https://docs.lando.dev/core/v3/nginx.html).
[PHP](https://www.php.net/) is a popular scripting language that is especially suited for web development. It is often served by either [apache](https://docs.lando.dev/core/v3/apache.html) or [nginx](https://docs.lando.dev/core/v3/nginx.html).

You can easily add it to your Lando app by adding an entry to the [services](https://docs.lando.dev/core/v3/lando-service.html) top-level config in your [Landofile](https://docs.lando.dev/core/v3).

Expand All @@ -31,7 +31,7 @@ services:
## Legacy versions
::: warning Using Unsupported PHP Versions!
While you can currently use some [EOL php version](http://php.net/supported-versions.php) with Lando, it's worth noting that we also do not support such versions, so your mileage may vary. If you are having issues with unsupported versions and open a ticket about it, the most likely response you will get is "upgrade to a supported version".
While you can currently use some [EOL php version](https://www.php.net/supported-versions.php) with Lando, it's worth noting that we also do not support such versions, so your mileage may vary. If you are having issues with unsupported versions and open a ticket about it, the most likely response you will get is "upgrade to a supported version".
:::
You can still run these versions with Lando but for all intents and purposes they should be considered deprecated (e.g. YMMV and do not expect a ton of support if you have an issue).
Expand Down

0 comments on commit 8ffbbc8

Please sign in to comment.