Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Falsely declared support for MOI.Integer #244

Closed
odow opened this issue Jun 23, 2024 · 1 comment · Fixed by #245
Closed

Falsely declared support for MOI.Integer #244

odow opened this issue Jun 23, 2024 · 1 comment · Fixed by #245
Labels
bug

Comments

@odow
Copy link
Collaborator

odow commented Jun 23, 2024

This should be false:

Alpine.jl/src/MOI_wrapper/MOI_wrapper.jl

Lines 325 to 331 in a1849dd

function MOI.supports_constraint(
::Optimizer,
::Type{MOI.VariableIndex},
::Type{MOI.Integer},
)
return true
end

See jump-dev/MathOptInterface.jl#2517
@odow odow added the bug label Jun 23, 2024
@odow odow mentioned this issue Jun 23, 2024
Closed
@LebedevRI
Copy link
Contributor

LebedevRI commented Jun 23, 2024 •
edited
Loading

But won't that also forbid Binary variables?

LebedevRI added a commit to LebedevRI/Alpine.jl that referenced this issue Jun 27, 2024
@LebedevRI
Don't falsely claim that Integer variables are supported
526389b 
They really are not supported, and the claim is only there
to provide a nice diagnostic.

But that prevents MOI `IntegerToZeroOneBridge` from triggering,
and providing Alpine with transparent support for them.

Fixes lanl-ansi#244
@LebedevRI LebedevRI mentioned this issue Jun 27, 2024
Merged
LebedevRI added a commit to LebedevRI/Alpine.jl that referenced this issue Jun 27, 2024
@LebedevRI
Don't falsely claim that Integer variables are supported
e7c72c4 
They really are not supported, and the claim is only there
to provide a nice diagnostic.

But that prevents MOI `IntegerToZeroOneBridge` from triggering,
and providing Alpine with transparent support for them.

Fixes lanl-ansi#244
LebedevRI added a commit to LebedevRI/Alpine.jl that referenced this issue Jun 28, 2024
@LebedevRI
Don't falsely claim that Integer variables are supported
e8c0263 
They really are not supported, and the claim is only there
to provide a nice diagnostic.

But that prevents MOI `IntegerToZeroOneBridge` from triggering,
and providing Alpine with transparent support for them.

Fixes lanl-ansi#244
LebedevRI added a commit to LebedevRI/Alpine.jl that referenced this issue Jul 14, 2024
@LebedevRI
Don't falsely claim that Integer variables are supported
0a28865 
They really are not supported, and the claim is only there
to provide a nice diagnostic.

But that prevents MOI `IntegerToZeroOneBridge` from triggering,
and providing Alpine with transparent support for them.

Fixes lanl-ansi#244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't erroneously claim support for Integer variables LebedevRI/Alpine.jl
2 participants
@LebedevRI @odow