Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the camera in the correct place in the zau inesc datasets? #970

Closed
miguelriemoliveira opened this issue Jul 13, 2024 · 8 comments
Closed
Assignees
Labels
discussion Issue for discussing a topic

Comments

@miguelriemoliveira
Copy link
Member

FYI @manuelgitgomes and @Kazadhum ,

I don't think it is ... I mean when correcting the odometry I had strange projections like in these examples:

image

from this one it seems that the robot arm is not correctly aligned

image

This one is also strange

image

Here's the positioning of the camera

image

@miguelriemoliveira miguelriemoliveira added the discussion Issue for discussing a topic label Jul 13, 2024
@miguelriemoliveira miguelriemoliveira self-assigned this Jul 13, 2024
@miguelriemoliveira
Copy link
Member Author

miguelriemoliveira commented Jul 13, 2024

I tried to calibrate with hand camera rgb + another rgb and the calibration does not converge.
I think this is the problem. Initial guess for the hand rg and hand depth is very wrong ...

@manuelgitgomes
Copy link
Collaborator

Hello @miguelriemoliveira!

I am fairly certain the hand camera is rotated 180º in roll.
That should be fairly easy to rotate hardcoded in the dataset.
But, if you have the will to work on #971, that would be nice as well.

@miguelriemoliveira
Copy link
Member Author

I am fairly certain the hand camera is rotated 180º in roll.
That should be fairly easy to rotate hardcoded in the dataset.
But, if you have the will to work on #971, that would be nice as well.

Thanks @manuelgitgomes . I think #971 is better because usually my 3 month long searches for the correct transformation always start like this: I am fairly certain that we need to rotate this x degrees ... :)

@Kazadhum
Copy link
Collaborator

Ah, it looks like I might have made a mistake when inserting the camera in the URDF when we were over at INESC... 😅

@miguelriemoliveira
Copy link
Member Author

Ah, it looks like I might have made a mistake when inserting the camera in the URDF when we were over at INESC... 😅

Yeah, that happens to everyone. That's why we need #971

@miguelriemoliveira
Copy link
Member Author

Correcting using transform_corrector.

image

image

It's not perfect, but much better.

@miguelriemoliveira
Copy link
Member Author

It was mostly about rotating the camera 180 degrees.

@miguelriemoliveira
Copy link
Member Author

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Issue for discussing a topic
Development

No branches or pull requests

3 participants