Replies: 1 comment
-
Not a fan, because the Settings in BLE are only in context of BLE (in this case to a buffer that is needed for bluetooth). Now there is a nice separation of concern. Also (more pure technical reason): it would make the templating much more difficult (initial gut reaction). |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Arduino-BLE-MIDI/src/BLEMIDI_Settings.h
Lines 7 to 10 in 8dee1f7
It would be :
struct DefaultSettings : public MIDI_NAMESPACE::DefaultSettings
It would allow using the same config Struct to set BleMidiTransport and MidiInterface at once. You would modify some settings of any of two layers in the same Struct. For example, edit
MaxBufferSize
of BLETransport andHandleNullVelocityNoteOnAsNoteOff
of MidiInterfaceIt may be useful for #58.
What do you think about it, @lathoub?
Beta Was this translation helpful? Give feedback.
All reactions