Not diamond compatible?

[phated]

I'm noticing that the Persona contracts all use plain contract storage instead of AppStorage or DiamondStorage. Why aren't these contracts Diamond compatible?

[ludns]

Good question!
They are meant to be deployed once per chain, not once per game. They live as independent contracts.
From your Diamond you can simply call the corresponding Persona deployments.

import { PersonaMirror } from 'persona/L2/PersonaMirror.sol';
contract Example {
  PersonaMirror public personaMirror;
  constructor(address _personaMirror) {
    personaMirror = PersonaMirror(_personaMirror);
  }
  function getPersona() internal view returns (uint256) {
    uint256 personaId = personaMirror.getActivePersona(msg.sender, address(this));
    require(personaMirror.isAuthorized(personaId, msg.sender, address(this), msg.sig), 'persona not authorized');
    return personaId;
  }
}

[phated]

That makes sense! Maybe an example showing usage in a diamond would also be helpful, since the only example uses contract state.

If this is meant to be a deploy-once contract, shouldn't it be a diamond itself so it can be upgraded, expanded, or patched, while still allowing consumers to rely on the exact same contract address forever??