You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Not a problem per se, but ipnet has some advantages over ipnetwork (qoted from the discussion for the addition into diesel):
Diesel currently supports the ipnetwork crate for working with IP addresses and subnets in CIDR block notation. I'd like to propose an additional feature, allowing consumers to use the ipnet as well. The second crate presents a different API, such as facilities for managing subnetworks and traits for bitwise operations on addresses. ipnet is also significantly more popular than ipnetwork, though that may be a secondary concern.
From a compatibility point of view, ipnetwork is still under 1.0, which makes updates more time consuming, and new sqlx versions need to be published every time ipnetwork updates. ipnet should be an almost-direct port, since most (if not all) of the code for ipnetwork works for ipnet, just by changing the IpNetwork types to IpNet types. Also, both features should be able to work at the same time without any major issue.
Describe the solution you'd like
I would like to have a new ipnet feature, that uses the ipnet crate instead of the ipnetwork crate for handling PostgreSQL network types. The ipnetwork feature should still be available for those wanting to use this crate.
Additional context
The ipnet crate was recently added to diesel as an alternative for handling network types for PostgreSQL. It would be nice to have it in sqlx as well, and should be fairly straightforward to implement by borrowing code from the ipnetwork implementation.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
Not a problem per se, but
ipnet
has some advantages overipnetwork
(qoted from the discussion for the addition intodiesel
):From a compatibility point of view,
ipnetwork
is still under 1.0, which makes updates more time consuming, and newsqlx
versions need to be published every timeipnetwork
updates.ipnet
should be an almost-direct port, since most (if not all) of the code foripnetwork
works foripnet
, just by changing theIpNetwork
types toIpNet
types. Also, both features should be able to work at the same time without any major issue.Describe the solution you'd like
I would like to have a new
ipnet
feature, that uses theipnet
crate instead of theipnetwork
crate for handling PostgreSQL network types. Theipnetwork
feature should still be available for those wanting to use this crate.Additional context
The
ipnet
crate was recently added todiesel
as an alternative for handling network types for PostgreSQL. It would be nice to have it insqlx
as well, and should be fairly straightforward to implement by borrowing code from theipnetwork
implementation.The text was updated successfully, but these errors were encountered: