Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow loading all config from .app-config.secrets.* without .app-config.* #154

Open
DetachHead opened this issue May 18, 2021 · 1 comment

Comments

@DetachHead
Copy link

DetachHead commented May 18, 2021

Currently it throws an error when .app-config.yml isn't found, even if a .app-config.secrets.yml file exists with all of the required properties

@DetachHead DetachHead changed the title allow loading all config from .app-config.secrets.* without `.app allow loading all config from .app-config.secrets.* without .app-config.* May 18, 2021
@joelgallant
Copy link
Contributor

Interesting, that makes enough sense. FWIW if you need a workaround, you can of course just touch .app-config.yml.

In terms of implementing this suggestion, I think we'll need to catch a NotFoundError on the main config file source, try to validate only secrets, and in case of error, just throw up the NotFoundError again.

It's a bit tricky though, because you might be intending to just use app-config secrets, and happen to have a validation error. Maybe a warning log with the validation error is enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants