Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type hints unavailable from LDClient type export #714

Open
vhscom opened this issue Dec 16, 2024 · 1 comment
Open

Type hints unavailable from LDClient type export #714

vhscom opened this issue Dec 16, 2024 · 1 comment
Labels
bug Something isn't working package: sdk/cloudflare Label for issues affecting the sdk/cloudflare package.

Comments

@vhscom
Copy link

vhscom commented Dec 16, 2024

Describe the bug
When importing the client from the cloudflare package the JSDoc typings are not available.

To reproduce

Import your client like:

import {init, type LDClient} from '@launchdarkly/cloudflare-server-sdk';

Expected behavior

I would expect hovering over LDClient to provide JSDoc-style comments and type hints like:
Screenshot 2024-12-16 at 4 01 31 PM

Unfortunately, that only seems to be working when the client is imported from @launchdarkly/js-server-sdk-common.

Logs
n/a

SDK version
2.6.3

Language version, developer tools
JS core SDK package named cloudflare, VSCode

OS/platform
macOS

Additional context
Nice to have. Would make my life easier.

@vhscom vhscom added bug Something isn't working package: sdk/cloudflare Label for issues affecting the sdk/cloudflare package. labels Dec 16, 2024
@kinyoklion
Copy link
Member

Hello @vhscom,

Are you using typescript, and if so can you include a copy of your tsconfig?

Thank you,
Ryan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package: sdk/cloudflare Label for issues affecting the sdk/cloudflare package.
Projects
None yet
Development

No branches or pull requests

2 participants