Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strikethrough text in markdown editor #11538

Open
neoriae opened this issue Dec 19, 2024 · 2 comments
Open

Strikethrough text in markdown editor #11538

neoriae opened this issue Dec 19, 2024 · 2 comments
Labels
bug It's a bug

Comments

@neoriae
Copy link

neoriae commented Dec 19, 2024

Hello,
Here's a report of what I think is a bug.
Thanks in advance for reading!

Operating system

Windows

Joplin version

3.2.5

Desktop version info

Joplin 3.2.5 (prod, win32)
Révision : 2da789a

Current behaviour

Strikethrough text in the markdown editor is not previewed as strikethrough, whereas this works for bold or italic text.

New editor

Expected behaviour

I think it's better to display the strikethrough text in the markdown editor, even if it's perhaps a little less easy to read.

Legacy editor

@neoriae neoriae added the bug It's a bug label Dec 19, 2024
ARYPROGRAMMER added a commit to ARYPROGRAMMER/joplin that referenced this issue Dec 21, 2024
@ARYPROGRAMMER
Copy link

@laurent22 In the current implementation

bold
italic

these two functions are very well working in the markdown editor preview but the strikethrough functionality is not.

I could solve this by simply integrating the already existing strikethrough method and passing it as a param to the editor so that the behaviour specified in the image is obtained. Relavant updates are also done in docs as well as a shortcut key "Alt-shift-5" is been allotted to speed up the strikethrough process in the editor.

let me know further, although I think this would not require much of changes. Could also think of adding relavant tests for the same.

@laurent22
Copy link
Owner

We'll deal with this in our own time

Repository owner locked as off-topic and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug It's a bug
Projects
None yet
Development

No branches or pull requests

3 participants