Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partner Images #4222

Closed
HetviSoni opened this issue May 12, 2023 · 11 comments
Closed

Partner Images #4222

HetviSoni opened this issue May 12, 2023 · 11 comments
Assignees
Labels
kind/bug Something isn't working

Comments

@HetviSoni
Copy link
Contributor

Description

On the https://layer5.io/partners page, images of Hashicorp, HPE, and VMWare are not visible. There is a link to https://www.hashicorp.com/partners/tech/layer5 at Hashicorp image but may be incorrect.
image

Expected Behavior

Correct links need to be added

Environment:

  • Host OS:
  • Browser:

Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

@HetviSoni HetviSoni added the kind/bug Something isn't working label May 12, 2023
@sambhavgupta0705
Copy link
Contributor

Yes, they are not visible for light mode
I would like to work on this issue and fix it

@HetviSoni
Copy link
Contributor Author

Yes, they are not visible for light mode I would like to work on this issue and fix it

ya u are correct. Images are fine in dark mode but invisible in light.

@vishalvivekm
Copy link
Contributor

Thanks @HetviSoni for pointing it out.
Also, in the dark mode, the partners' names ("Microsoft", "Service Mesh Interface", "Cloud Native Computing Foundation (CNCF)") aren't quite visible
Screenshot from 2023-05-12 18-48-00

Will you see to it that these svgs support both light as well as dark mode? Who'd take up the issue? // @sambhavgupta0705 @HetviSoni

@HetviSoni
Copy link
Contributor Author

Thanks @HetviSoni for pointing it out. Also, in the dark mode, the partners' names ("Microsoft", "Service Mesh Interface", "Cloud Native Computing Foundation (CNCF)") aren't quite visible Screenshot from 2023-05-12 18-48-00

Will you see to it that these svgs support both light as well as dark mode? Who'd take up the issue? // @sambhavgupta0705 @HetviSoni

Let @sambhavgupta0705 take this up as he asked first ☺️

@sambhavgupta0705
Copy link
Contributor

ok @HetviSoni I will take this up

@vishalvivekm
Copy link
Contributor

Sounds good.

@randychilau
Copy link
Contributor

Hi Everyone,

It is great that so many folks want to help.

Organizers please note that this is a duplicate issue to the previously posted Issue #4146, and now there are multiple assignees for the same task. Please provide guidance on how to proceed.

Thanks,
Randy

@HetviSoni
Copy link
Contributor Author

I am sorry I did not notice that a similar issue was already opened. Should I close this one?

@randychilau
Copy link
Contributor

HI @HetviSoni,

No worries, I only mention this because I am assisting in the other thread with trying to help troubleshoot a local setup.

Happy with whatever the Organizers decide is best.

Cheers,
Randy

@vishalvivekm
Copy link
Contributor

Oh, thanks @randychilau

@HetviSoni To ensure we don't create duplicate issues, please search the existing issues before opening a new one.
For now, this issue can be closed. // @HetviSoni

@HetviSoni
Copy link
Contributor Author

Will keep that in mind👍Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Development

No branches or pull requests

4 participants