Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Use make, not npm directly #942

Open
leecalcote opened this issue Feb 26, 2025 · 1 comment
Open

[CI] Use make, not npm directly #942

leecalcote opened this issue Feb 26, 2025 · 1 comment
Labels
area/ci Continuous integration | Build and release help wanted Extra attention is needed issue/willfix This issue will be worked on

Comments

@leecalcote
Copy link
Member

Current Behavior

Direct use of npm is inconsistent with all of the other projects here.

Desired Behavior

  1. Create make targets reusing the include() make files from meshery/meshery.
  2. Follow the same target structure as other projects (e.g. make ui-setup; make ui-build; make site-setup; make site-build; make ui-lint).
  3. Update the README and Contributing guide.
  4. Update the GitHub workflows

Implementation

  1. Create make targets reusing the include() make files from meshery/meshery.
  2. Follow the same target structure as other projects (e.g. make ui-setup; make ui-build; make site-setup; make site-build; make ui-lint).
  3. Update the README and Contributing guide.
  4. Update the GitHub workflows

Acceptance Tests

  1. Sistent workflows are using make.

Contributor Guides and Resources

@leecalcote leecalcote added area/ci Continuous integration | Build and release help wanted Extra attention is needed issue/willfix This issue will be worked on labels Feb 26, 2025
@mdimado
Copy link

mdimado commented Feb 27, 2025

I'd like to work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous integration | Build and release help wanted Extra attention is needed issue/willfix This issue will be worked on
Development

No branches or pull requests

2 participants