Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auto-generate protobufs on push #26

Open
lyoshenka opened this issue Mar 4, 2019 · 2 comments
Open

auto-generate protobufs on push #26

lyoshenka opened this issue Mar 4, 2019 · 2 comments
Labels
type: discussion A conversation. No specific changes requested

Comments

@lyoshenka
Copy link
Member

otherwise we'll forget to run build.sh after each change

if committing generated code is not easy, at least error when build should have been run but wasnt
@alyssaoc alyssaoc added the type: discussion A conversation. No specific changes requested label Apr 5, 2019
@shyba
Copy link
Member

shyba commented Apr 5, 2019

its blocked by pinning protoc because if we use the wrong protoc its worse than not auto generating it

@lyoshenka
Copy link
Member Author

just include protoc binary in this repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: discussion A conversation. No specific changes requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@eukreign @lyoshenka @shyba @alyssaoc