Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

490 $3 producing Invalid bflc:AppliesTo output #246

Open
RichardWallis opened this issue Aug 27, 2024 · 2 comments
Open

490 $3 producing Invalid bflc:AppliesTo output #246

RichardWallis opened this issue Aug 27, 2024 · 2 comments

Comments

@RichardWallis
Copy link

RichardWallis commented Aug 27, 2024

Following spec documentation, the following:

        <marc:datafield tag="490" ind1="1" ind2=" ">
            <marc:subfield code="6">880-04</marc:subfield>
            <marc:subfield code="3">2016- :</marc:subfield>

should result in:

          <bflc:appliesTo>
            <bflc:AppliesTo>
                <rdfs:label>2016- :<rdfs:label>
            </bflc:AppliesTo>
          </bflc:appliesTo>

But instead the following is output:

          <bflc:appliesTo>
            <bflc:AppliesTo>2016- :</bflc:AppliesTo>
          </bflc:appliesTo>

Identified in release version 2.0.2 but quick check shows issue also in version 2.7

3 example marcxml files demonstrating the issue, zipped and attached.
3examples.zip

@kefo
Copy link
Member

kefo commented Aug 30, 2024

Thanks, Richard. Very helpful.

This has been fixed in the new branch for 2.8 development. You can see the tests are passing and the only changes I made were the result of your records: https://github.com/lcnetdev/marc2bibframe2/commits/v2.8-dev/ Incidentally, I moved the 'appliesTo' resource from out of the Series resource to the Relation resource, which is more appropriate.

Let me know if you'd rather me create a .1 release of 2.7 or if you just want to move on to this version of the code.

About this odd phrasing: "the only changes I made were the result of your records." I noticed no ProvisionActivity resources were coming from the 264s (and corresponding 880s) in your sample records. I fixed that too. The code that deals with 008 provision information and 26X fields employs some mad XSLT so keep an eye on the output for PAs. I don't think I broke anything (and there was decent test coverage for PAs already and those are all passing).

@RichardWallis
Copy link
Author

RichardWallis commented Sep 10, 2024

Thanks for this Kevin.

The option of a 2.7.1 is appealing however the site I am working with is a way behind in its version (2.0.2).

Is the fix isolated enough to make a backport patch to 2.0.2 feasible?

~Richard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants