Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM Custom Form: Bound-withs #162

Open
rjyounes opened this issue May 14, 2018 · 11 comments
Open

ARM Custom Form: Bound-withs #162

rjyounes opened this issue May 14, 2018 · 11 comments

Comments

@rjyounes
Copy link
Collaborator

No description provided.

@hudajkhan
Copy link
Contributor

Item is part of a bound-with item. Item can be ordered with respect to other items that are also part of a bound-width.

@rjyounes rjyounes self-assigned this May 18, 2018
@rjyounes
Copy link
Collaborator Author

Ready for review. The faux property label should read "Part of bound collection" rather than "Part of item," but I believe this will happen once the SHACL has been rerun. The form title "Add an entry of type Item for X" should also be changed to "Add an entry of type Bound Collection for X," but that may also be changed once the new SHACL with sh:class BoundCollection is read in.

@sfolsom
Copy link
Collaborator

sfolsom commented Jun 1, 2018

The SHACL in raremat_monograph_form.ttl still has an Item being part of sh:class bf:Item. Should I change that to arm:BoundCollection?

@rjyounes
Copy link
Collaborator Author

rjyounes commented Jun 1, 2018

@rjyounes
Copy link
Collaborator Author

rjyounes commented Jun 6, 2018

Ready for review, with the caveats described in issues #207, #208, #209, #210, and #211. @sfolsom Can you please prioritize these issues? I don't know if we can get to any of them before the workshop, but it would at least be good to have a sense of what's important.

@rjyounes
Copy link
Collaborator Author

rjyounes commented Jun 6, 2018

Assigning to @sfolsom for review.

@sfolsom
Copy link
Collaborator

sfolsom commented Jun 6, 2018

When clicking save on a BoundCollection, it doesn't show up in the list view. Do we need a list view config?

@rjyounes rjyounes assigned hudajkhan and unassigned sfolsom Jun 6, 2018
@rjyounes
Copy link
Collaborator Author

rjyounes commented Jun 6, 2018

The current code has not been deployed. Please hold off on reviewing items that are not in the For Review column. (In this case I accidentally put it there forgetting that it needs to be deployed first, so I've created a new column for Deployment so Huda is aware of the need.

@sfolsom
Copy link
Collaborator

sfolsom commented Jun 6, 2018

Sorry. I got mixed up between the in progress column and for review.

@rjyounes
Copy link
Collaborator Author

rjyounes commented Jun 7, 2018

Still cannot add an existing bound collection, but needs to be deployed as is. New issue #216 created.

@hudajkhan
Copy link
Contributor

code has been deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants