From 325b6cc6c81657f3d577c7c2ed4e0c7a1cb261f2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jakub=20Fija=C5=82kowski?= <kuba@codinginfinity.me>
Date: Mon, 30 Dec 2024 14:34:10 +0100
Subject: [PATCH] Remove CodeAnalysis ruleset as it is not used

It also won't be distributed with the LeanCode.CodeAnalysis project.
Each project should specify their own rules (or base it on .editorconfig
file, but not ruleset for sure).

This fixes the `Pack` step.
---
 LeanCode.CodeAnalysis.ruleset                 | 119 ------------------
 .../LeanCode.CodeAnalysis.csproj              |   3 -
 .../LeanCode.CodeAnalysis.props               |   6 -
 3 files changed, 128 deletions(-)
 delete mode 100644 LeanCode.CodeAnalysis.ruleset
 delete mode 100644 src/Tools/LeanCode.CodeAnalysis/LeanCode.CodeAnalysis.props

diff --git a/LeanCode.CodeAnalysis.ruleset b/LeanCode.CodeAnalysis.ruleset
deleted file mode 100644
index e198ee4ab..000000000
--- a/LeanCode.CodeAnalysis.ruleset
+++ /dev/null
@@ -1,119 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<RuleSet Name="LeanCode RuleSets" ToolsVersion="15.0">
-    <Rules AnalyzerId="Microsoft.CodeAnalysis" RuleNamespace="Microsoft.CodeAnalysis.Diagnostics">
-        <Rule Id="IDE0054" Action="None"/>
-        <!-- UseCompoundAssignmentDiagnostic - requires preview language  -->
-        <Rule Id="IDE0063" Action="None"/>
-        <!-- UseSimpleUsingStatementDiagnostic -->
-        <Rule Id="IDE0066" Action="None"/>
-        <!-- ConvertSwitchStatementToExpression -->
-
-        <Rule Id="CA1002" Action="None"/>
-        <!-- DoNotExposeGenericLists - this rule doesn't affect us -->
-        <Rule Id="CA1014" Action="None"/>
-        <!-- MarkAssembliesWithClsCompliant - we are not CLS compliant deliberately -->
-        <Rule Id="CA1019" Action="None"/>
-        <!-- DefineAccessorsForAttributeArguments - not really needed -->
-        <Rule Id="CA1030" Action="None"/>
-        <!-- UseEventsWhereAppropriate - we won't use events anyway -->
-        <Rule Id="CA1032" Action="None"/>
-        <!-- ImplementStandardExceptionConstructors - we deliberately ignore some constructors -->
-        <Rule Id="CA1062" Action="None"/>
-        <!-- ValidateArgumentsOfPublicMethods - we rely on NRT -->
-        <Rule Id="CA1303" Action="None"/>
-        <!-- DoNotPassLiteralsAsLocalizedParameters - we don't support localization in places where this is enabled -->
-        <Rule Id="CA1308" Action="None"/>
-        <!-- NormalizeStringsToUppercase - we know what we're doing -->
-        <Rule Id="CA1707" Action="None"/>
-        <!-- IdentifiersShouldNotContainUnderscores - disabling it only for tests is too painful -->
-        <Rule Id="CA1716" Action="None"/>
-        <!-- IdentifiersShouldNotMatchKeywords - we really don't care about VB.NET or C++/CLI -->
-        <Rule Id="CA1720" Action="None"/>
-        <!-- IdentifiersShouldNotContainTypeNames - we don't really care about it -->
-        <Rule Id="CA1816" Action="None"/>
-        <!-- DisposeMethodsShouldCallSuppressFinalize - we don't use finalizers that much -->
-        <Rule Id="CA2007" Action="None"/>
-        <!-- DoNotDirectlyAwaitATaskAnalyzer - we don't need that -->
-        <Rule Id="CA2234" Action="None"/>
-        <!-- PassSystemUriObjectsInsteadOfStrings - most of the time it will result in an exception -->
-    </Rules>
-
-    <Rules AnalyzerId="StyleCop.Analyzers" RuleNamespace="StyleCop.Analyzers">
-        <Rule Id="SA0001" Action="None"/>
-        <!-- XmlCommentAnalysisDisabled -->
-
-
-        <Rule Id="SA1101" Action="None"/>
-        <!-- PrefixLocalCallsWithThis -->
-        <Rule Id="SA1104" Action="None"/>
-        <!-- QueryClausesSpanningMultipleLines -->
-        <Rule Id="SA1117" Action="None"/>
-        <!-- ParametersMustBeOnSameLineOrSeparateLines -->
-        <Rule Id="SA1118" Action="None"/>
-        <!-- ParameterMustNotSpanMultipleLines -->
-        <Rule Id="SA1122" Action="None"/>
-        <!-- UseStringEmptyForEmptyStrings -->
-        <Rule Id="SA1129" Action="None"/>
-        <!-- DoNotUseDefaultValueTypeConstructor -->
-
-
-        <Rule Id="SA1201" Action="None"/>
-        <!-- ElementsMustAppearInTheCorrectOrder -->
-        <Rule Id="SA1202" Action="None"/>
-        <!-- ElementsMustBeOrderedByAccess -->
-        <Rule Id="SA1204" Action="None"/>
-        <!-- StaticElementsMustAppearBeforeInstanceElements -->
-
-
-        <Rule Id="SA1316" Action="None"/>
-        <!-- TupleElementNamesShouldUseCorrectCasing -->
-
-
-        <Rule Id="SA1402" Action="None"/>
-        <!-- FileMayOnlyContainASingleType -->
-        <Rule Id="SA1407" Action="None"/>
-        <!-- ArithmeticExpressionsMustDeclarePrecedence  -->
-        <Rule Id="SA1414" Action="None"/>
-        <!-- TupleTypesInSignaturesShouldHaveElementNames  -->
-
-
-        <Rule Id="SA1502" Action="None"/>
-        <!-- ElementMustNotBeOnSingleLine -->
-        <Rule Id="SA1503" Action="Error"/>
-        <!-- BracesMustNotBeOmitted :) -->
-        <Rule Id="SA1512" Action="None"/>
-        <!-- SingleLineCommentsMustNotBeFollowedByBlankLine -->
-        <Rule Id="SA1515" Action="None"/>
-        <!-- SingleLineCommentMustBePrecededByBlankLine -->
-        <Rule Id="SA1516" Action="None"/>
-        <!-- ElementsMustBeSeparatedByBlankLine -->
-
-
-        <Rule Id="SA1600" Action="None"/>
-        <!-- ElementsMustBeDocumented -->
-        <Rule Id="SA1601" Action="None"/>
-        <!-- PartialElementsMustBeDocumented -->
-        <Rule Id="SA1602" Action="None"/>
-        <!-- EnumerationItemsMustBeDocumented -->
-        <Rule Id="SA1604" Action="None"/>
-        <!-- ElementDocumentationMustHaveSummary -->
-        <Rule Id="SA1610" Action="None"/>
-        <!-- PropertyDocumentationMustHaveValueText -->
-        <Rule Id="SA1611" Action="None"/>
-        <!-- ElementParametersMustBeDocumented -->
-        <Rule Id="SA1615" Action="None"/>
-        <!-- ElementReturnValueMustBeDocumented -->
-        <Rule Id="SA1618" Action="None"/>
-        <!-- GenericTypeParametersMustBeDocumented -->
-        <Rule Id="SA1623" Action="None"/>
-        <!-- PropertySummaryDocumentationMustMatchAccessors -->
-        <Rule Id="SA1629" Action="None"/>
-        <!-- DocumentationTextMustEndWithAPeriod -->
-        <Rule Id="SA1633" Action="None"/>
-        <!-- FileMustHaveHeader -->
-        <Rule Id="SA1642" Action="None"/>
-        <!-- ConstructorSummaryDocumentationMustBeginWithStandardText -->
-        <Rule Id="SA1649" Action="None"/>
-        <!-- FileNameMustMatchTypeName -->
-    </Rules>
-</RuleSet>
diff --git a/src/Tools/LeanCode.CodeAnalysis/LeanCode.CodeAnalysis.csproj b/src/Tools/LeanCode.CodeAnalysis/LeanCode.CodeAnalysis.csproj
index 274a85fa1..3f4012e2b 100644
--- a/src/Tools/LeanCode.CodeAnalysis/LeanCode.CodeAnalysis.csproj
+++ b/src/Tools/LeanCode.CodeAnalysis/LeanCode.CodeAnalysis.csproj
@@ -17,9 +17,6 @@
   <ItemGroup>
     <None Include="$(OutputPath)/$(AssemblyName).dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" />
 
-    <None Include="LeanCode.CodeAnalysis.props" Pack="true" PackagePath="build" />
-    <None Include="$(CodeAnalysisSettingsLocation)/LeanCode.CodeAnalysis.ruleset" Pack="true" PackagePath="build" />
-
     <AdditionalFiles Include="AnalyzerReleases.Shipped.md" />
   </ItemGroup>
 </Project>
diff --git a/src/Tools/LeanCode.CodeAnalysis/LeanCode.CodeAnalysis.props b/src/Tools/LeanCode.CodeAnalysis/LeanCode.CodeAnalysis.props
deleted file mode 100644
index 612024e1e..000000000
--- a/src/Tools/LeanCode.CodeAnalysis/LeanCode.CodeAnalysis.props
+++ /dev/null
@@ -1,6 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<Project ToolsVersion="Current" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
-  <PropertyGroup>
-    <CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)LeanCode.CodeAnalysis.ruleset</CodeAnalysisRuleSet>
-  </PropertyGroup>
-</Project>