Addrspace #163
Closed
Addrspace #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the client_as address space in clang. It is still not used anywhere, just declared.
In clang, all values of client type are implicitly put in the client_as address space. In llvm this translates to the address space 1 for pointers to client types. Nothing is actually done with this information yet.
In preparation for the switch to opaque pointers, get the information from the pointer itself (through the address space) instead of the element type.
These come up from temporaries of client types, since allocas are in the default address space, while client types are forced to be in the client address space. Clang here just blindly do a bitcast because the types are different, but it needs to be specifically an address cast. A proper solution would be to have the allocas themselves use the client address space, but that's going to be a much bigger change to clang
|
closing this since at this point the PR will include a more general approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First batch for the address space work.
This introduces an address space for pointers to client types, and uses it to detect those pointers in PA (with an assertion that the answer matches previous behavior).
Hopefully some of this prepares the way for further use of address spaces.
The first two commits are actually independent but related in scope (removal of some uses of pointer types)