Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging successful writes that do not pass the test. #15

Closed
jbusecke opened this issue Aug 24, 2023 · 1 comment
Closed

Logging successful writes that do not pass the test. #15

jbusecke opened this issue Aug 24, 2023 · 1 comment

Comments

@jbusecke
Copy link
Collaborator

I just investigated some cases of failed jobs, which wrote a store, but failed the test stage. I propose to also log these stores, but in a different BigQuery table.

Some background:
iid: CMIP6.ScenarioMIP.NIMS-KMA.UKESM1-0-LL.ssp585.r14i1p1f2.day.sfcWind.gn.v20210428
submitting gh workflow
Dataflow job
Zarr Store: gs://leap-persistent-ro/data-library/cmip6-testing/a618127503-5957190341-2/CMIP6.ScenarioMIP.NIMS-KMA.UKESM1-0-LL.ssp585.r14i1p1f2.day.sfcWind.gn.v20210428.zarr
Failed due to:

RuntimeError: AssertionError [while running 'Create|OpenURLWithFSSpec|OpenWithXarray|Preprocessor|StoreToZarr|TestDataset|LogToBigQuery/TestDataset/Testing - Time Dimension-ptransform-53']

indicating that the test stage failed.

Investigating the store a bit more, it turns out that the time has gaps.
image

Now I think that fixing this sort of thing is beyond our mission here, but some researchers might want to investigate this more, and we should not keep them from it. I think this goes back to the idea @naomi-henderson established of a QC/non-QC catalog.

This would also help preventing to run these again and again, as they will fail every time.

@jbusecke
Copy link
Collaborator Author

jbusecke commented Sep 1, 2023

Closed via #9

@jbusecke jbusecke closed this as completed Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant