You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We already have a backup option.
We need to add a restore option.
We already have a Sysconfig variable "backupdir" I'd say we should simply present a filtered list of files to restore from there.
Those files should be real files, not symlinks, and match a regex along the lines of $DBname.*\.$backupExtension
That way there is no risk of file discovery on the server,
Of course this assumes the autonaming of generated backups matches that regex
The above mechanism removes the need to either allow Huge Uploads, or server Filesystem browsing
In the future we may want to allow copy paste of an scp or http URI with appropriate Auth prompts, although that's out of scope for this issue.
type:enhancementProposed improvement, new feature, or extension -- not a defectbite-sizedDeemed a good starting point for new contributors to learn about the code base.
1 participant
Converted from issue
This discussion was converted from issue #2543 on November 12, 2023 10:09.
Heading
Bold
Italic
Quote
Code
Link
Numbered list
Unordered list
Task list
Attach files
Mention
Reference
Menu
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
We already have a backup option.
We need to add a restore option.
We already have a Sysconfig variable "backupdir" I'd say we should simply present a filtered list of files to restore from there.
Those files should be real files, not symlinks, and match a regex along the lines of
$DBname.*\.$backupExtension
That way there is no risk of file discovery on the server,
Of course this assumes the autonaming of generated backups matches that regex
The above mechanism removes the need to either allow Huge Uploads, or server Filesystem browsing
In the future we may want to allow copy paste of an scp or http URI with appropriate Auth prompts, although that's out of scope for this issue.
Beta Was this translation helpful? Give feedback.
All reactions