Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are so many class XMLUtil members inline? #365

Open
Dmitry-Me opened this issue Jul 30, 2015 · 1 comment
Open

Why are so many class XMLUtil members inline? #365

Dmitry-Me opened this issue Jul 30, 2015 · 1 comment

Comments

@Dmitry-Me
Copy link
Contributor

I see that even StringEqual() is declared inline. Is that necessary? What would happen if it was inside the .cpp?

@leethomason
Copy link
Owner

There was some intent for performance, but it went too far. And clutters the headers. I'd support moving the larger ones (StringEqual) inline, but leave the small ones (IsUTF8Continuation.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants