Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear convertion TinyXML1 to TinyXML2 #440

Open
alphaonex86 opened this issue Jun 2, 2016 · 4 comments
Open

Unclear convertion TinyXML1 to TinyXML2 #440

alphaonex86 opened this issue Jun 2, 2016 · 4 comments

Comments

@alphaonex86
Copy link

Hello,

Can you write a guide to convert TinyXML1 to TinyXML2? It's very important if you wish deprecated the TinyXML1.
I'm blocked on https://github.com/alphaonex86/CatchChallenger/blob/version-2/server/base/TinyXMLSettings.cpp line 28,29,60,61,100,102
My macro for the dual compatibility is here:
https://github.com/alphaonex86/CatchChallenger/blob/version-2/general/base/GeneralVariable.h

Cheers,

@leethomason
Copy link
Owner

@alphaonex86 it's a great request; I regret not writing that long ago when it was fresh in my mind. A couple people have mentioned posting some docs and I hope they will.

I don't generally recommend a macro unless you really need both versions. There are some differences (in iteration, stdio support) that are hard to abstract.

@alphaonex86
Copy link
Author

alphaonex86 commented Jun 3, 2016

Then you are into a good position to start from near 0 to understand what a beginer see.

I plan have support of tinyXML 1, 2 and pugixml, then the macro is usefull. Not class, yes... I can't cut the support of version 1 util I have a full version 2 working and test with my data set against pugixml too.

@leethomason
Copy link
Owner

I have long forgotten how TinyXML-1 works.

@leethomason
Copy link
Owner

...at least to the level of being able to write an insightful migration guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants