Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splash Generation Improvements #177

Open
2 tasks
leichter opened this issue Jun 5, 2014 · 1 comment
Open
2 tasks

Splash Generation Improvements #177

leichter opened this issue Jun 5, 2014 · 1 comment

Comments

@leichter
Copy link
Owner

leichter commented Jun 5, 2014

  • Reuse Phantom processes in splash generation. It would be nice to reuse phantomjs processes when generating splash images (and just open a new page) and not have to create/kill the processes each time. The tricky thing here would be ensuring that one splash generation is finished before telling the phantom process to start on another. Could almost turn this into a task queue of sorts.
  • Download thumbnail images locally. Rather than templating in the urls we receive directly from the client, download the thumbnail images and save them locally. This way we could avoid doing hacky logic to switch protocols, and we could take advantage of caching the thumbnails for multiple requests.
@leichter leichter self-assigned this Jun 5, 2014
@leichter leichter changed the title Reuse Phantom Processes in Splash Generation Splash Generation Improvements Nov 20, 2014
@leichter
Copy link
Owner Author

leichter commented Jun 8, 2015

Some version of the first of these two bullet points needs to be implemented for the purposes of throttling requests to the splash generation endpoint. I was able to basically shut down a test ec2 instance by asking it to generate 100 splash images at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant