Cap skip timer to video duration

[leichter]

The data.skip property is always being set to 30 for selfie users' cards. However, if a selfie user's card has a video shorter than 30 seconds, the end user viewing the card will be stuck watching an ended video until the skip timer completes.

Since we're fetching and setting the video duration on the backend, we can have the backend cap the skip timer to the video duration; so if the data.skip property is a number greater than data.duration, it'll set data.skip to data.duration. This would mean that it'd be impossible for anyone to set a skip greater than the video duration, which I don't know if we want to make possible (to force users to read text on card or something).

cc @howardengelhart, @sqmunson

[howardengelhart]

@leichter - for selfie campaigns, lets change it to default at 5 seconds, ASAP.

[sqmunson]

@leichter Is this something I should do on the front end?

[leichter]

@sqmunson changing the default to 5 seconds ASAP is something I will do via policy change - aka all selfie users will now have 5 as the default value for data.skip. I'm also going to do a quick update to existing selfie campaigns' cards to set that. So I don't think you should need to do anything, unless you can think of issues this would cause in the frontend.

[sqmunson]

I'm currently setting data.skip to 30 seconds on front end but I guess that doesn't matter since you override it anyway. I'll add an issue to minireelinator to stop setting data.skip entirely.

[sqmunson]

That last comment is for Selfie only. I'll have to take a look at Campaign Manager to determine side effects there.

[sqmunson]

@leichter In the campaign manager data.skip can be set to true, false or a number (seconds). If true the user can skip any time, if false the user must watch the entire video, if it's a number the user can skip after countdown. Your service should probably respect a boolean value but could use your new logic for any numeric value?

[leichter]

@sqmunson if a user can set the data.skip value, they can set a value of any type (boolean or number) and the service will respect that. If they cannot set the data.skip value, it will default to 30. The logic for capping the skip timer to the video duration will obviously only take effect if data.skip is numerical.

[sqmunson]

@leichter So if a Selfie campaign/card is created and does not yet have a video, and therefore no duration to check, data.skip will be defaulted to 5 seconds? Or does the service wait for a valid video? What happens with VAST tags?

[leichter]

@sqmunson if a card does not yet have a video, the data.skip will still be defaulted to 5 seconds. The duration will only be checked once there is a valid video in there, and thus the data.skip will only be capped if there is a valid video with a fetchable duration.

We can check the duration on VAST tags, so they are treated the same as other valid videos.