Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check budget + end date when renewing campaigns #885

Open
leichter opened this issue May 2, 2016 · 0 comments
Open

Check budget + end date when renewing campaigns #885

leichter opened this issue May 2, 2016 · 0 comments
Labels

Comments

@leichter
Copy link
Owner

leichter commented May 2, 2016

When submitting a renewal request:

  • if the campaign is outOfBudget, the update request should be increasing the campaign's pricing.budget
  • if the campaign is expired, the update request should be increasing the campaign's endDate

Failing either of these conditions should return a 400.

Additionally, if a campaign is expired, outOfBudget, or canceled, submitting an update request that does not change the status (aka. is not a renewal) should probably return a 400.

cc @sqmunson @howardengelhart

@leichter leichter self-assigned this May 2, 2016
@leichter leichter added the ads label May 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant