Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for users.admin.setInactive, need advice for integration #62

Open
brontolinux opened this issue Jan 21, 2019 · 0 comments

Comments

@brontolinux
Copy link

Hi there

I forked your work and implemented support for users.admin.setInactive and I would like to help you integrate it in your code if you so wish.

users.admin.setInactive is an undocumented method of the Slack API that makes a user inactive. The unofficial documentation says that you need a legacy token in order for it to work, but it actually worked for me using an application I defined on Slack and a OAuth token with the client scope.

I am still learning Go, so in order to test my implementation I couldn't think of anything better than replacing all occurrences of your repo's references with mine and use go get -u to install my package again at each iteration. As a result, many files were changed but the ones that should be actually integrated are only four:

  • client.go
  • endpoints.json
  • interface.go
  • services.go

If you wish to integrate my changes I can surely restore the references to your repository and open a pull request, or do anything you suggest to make my changes suitable for integration. Just let me know.

Thanks
-- Marco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant