Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ban kwargs? #29

Open
MatthewCaseres opened this issue Apr 5, 2024 · 3 comments
Open

ban kwargs? #29

MatthewCaseres opened this issue Apr 5, 2024 · 3 comments

Comments

@MatthewCaseres
Copy link
Collaborator

MatthewCaseres commented Apr 5, 2024

I don't think the model you developed supports them. they are pretty annoying, should I stop supporting them as well? Should you start supporting them? Does it matter?

@MatthewCaseres MatthewCaseres changed the title ban kwargs ban kwargs? Apr 5, 2024
@lewisfogden
Copy link
Owner

hmm I use them a lot, e.g. passing in the data/basis and any top level functions, e.g.:

image

Is that where you are meaning?

@MatthewCaseres
Copy link
Collaborator Author

it appears that your code does not recognize kwargs as a key in the cache

https://github.com/lewisfogden/heavylight/blob/main/src/heavylight/heavylight.py#L17

@lewisfogden
Copy link
Owner

Oh I see! Yes I think pretty much all methods are positional (and 99% are t), so kwargs won't work.

Would we just need to update to

def __call__(self, *arg, /):

Also tempted just to leave it as it'll warn people anyway, and pop something in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants