Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PFP collections recommendations #912

Open
6 tasks
fricoben opened this issue Nov 15, 2024 · 2 comments
Open
6 tasks

Add PFP collections recommendations #912

fricoben opened this issue Nov 15, 2024 · 2 comments
Labels
Good first issue Good for newcomers OD Hack Issue reserved for the OD Hack Open for contribution An issue that is available for an Only Dust contribution

Comments

@fricoben
Copy link
Contributor

Description 📹

In constant.ts and the NftCollections const we have only two collection recommendations we need to add more

Proposed Actions 🛠️

Here’s a checklist of actions to follow for resolving this issue:

  1. Fork and Create Branch:
    Fork the repository and create a new branch using the issue number:

    git checkout -b fix-[issue-number]
  2. Implement Changes:
    Please add images and title for these collections:

  1. Run Tests and Commit Changes:
    Make sure your changes don't break existing functionality and commit with a clear message:
    git commit -m "Fix: [Short description of the fix]"

Required 📋

To keep our workflow smooth, please make sure you follow these guidelines:

  • Assignment: Don't create a pull request if you weren’t assigned to this issue.
  • Timeframe: Complete the task within 3 business days.
  • Closing the Issue: In your PR description, close the issue by writing Close #[issue_id].
  • Review Process:
    • Once you've submitted your PR, change the label to "ready for review".
    • If changes are requested, address them and then update the label back to "ready for review" once done.
  • Testing: Test your PR locally before pushing, and verify that tests and build are working after pushing.

Thank you for your contribution 🙏

⚠️ WARNING: Failure to follow the requirements above may result in being added to the OnlyDust blacklist, affecting your ability to receive future rewards.

@fricoben fricoben added Good first issue Good for newcomers OD Hack Issue reserved for the OD Hack Open for contribution An issue that is available for an Only Dust contribution labels Nov 15, 2024
@NueloSE
Copy link

NueloSE commented Nov 20, 2024

@fricoben kindly assign me this issue

@petersdt
Copy link

@fricoben can i take on this issue when odhack starts

ETA <= 24hrs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Good for newcomers OD Hack Issue reserved for the OD Hack Open for contribution An issue that is available for an Only Dust contribution
Projects
None yet
Development

No branches or pull requests

3 participants