Skip to content
This repository has been archived by the owner on Oct 3, 2024. It is now read-only.

Cannot exit tutorial building when tutorial is done #18

Open
Daandeve opened this issue Apr 20, 2021 · 7 comments
Open

Cannot exit tutorial building when tutorial is done #18

Daandeve opened this issue Apr 20, 2021 · 7 comments
Labels
bug Something isn't working
Milestone

Comments

@Daandeve
Copy link
Contributor

Describe the bug
I am currently working on a new terminal UI, but I can't get past the tutorial. I cannot exit tutorial building when the cat command is executed. I am using the latest master branch commit

To Reproduce
Steps to reproduce the behavior:

  1. Start the mission
  2. Complete the tutorial

Screenshots
image

@Daandeve Daandeve added bug Something isn't working unconfirmed Not yet confirmed labels Apr 20, 2021
@lfuelling
Copy link
Owner

lfuelling commented Apr 20, 2021

The tutorial is not done if you only executed the command :)

You're supposed to send a message to the mission contact which in turn completes the tutorial and spawns the teleport marker by the door.
Maybe it would be a good idea to always show the teleport and cancel the mission instead when leaving before sending the text 🤔

Edit: The code is also buggy (here's the bug), you have to send the string "0wn3r" to the contact named "Omega" to complete the (buggy) tutorial.

@Daandeve
Copy link
Contributor Author

Daandeve commented Apr 20, 2021

Okay clear, but the contact is not showing up in my phone.
I build gcphone in to the script but the contactAdd is not getting triggered, I manually set 'phoneReady' to true but it does not fire.
The 'phoneReady' variable is nil when I log it, but I could not find the place that the variable could be changed

@lfuelling
Copy link
Owner

lfuelling commented Apr 20, 2021

Sorry, I've never used gcPhone, only esx_phone. :(

In the code, phoneReady is set here when the esx_phone:loaded event is fired. GcPhone doesn't seem to have an event that is fired when the plugin is initialized so you might as well just set this to true.

Regarding adding the contact, it seems like you need to trigger the gcPhone:addContact event, I assume (from looking at this) that the params for this are a display name and a number.

Unfortunately esx_redpill is using ESX notifications to act as "messages", so you would have to change that part as well (at least if you want to see the messages in gcphone).

@lfuelling
Copy link
Owner

Oh actually I'm stupid, there should be a teleport marker in any case, even if the tutorial is not done, so the bug is correct.

@lfuelling lfuelling removed the unconfirmed Not yet confirmed label Apr 20, 2021
@lfuelling lfuelling added this to the 1.0.0 milestone Apr 20, 2021
@Daandeve
Copy link
Contributor Author

I set the phoneReady to true and changed all functions to work with gcphone (in theory), but when I print out the phoneReady the value is nil even though I set the value to true in the main file

@lfuelling
Copy link
Owner

lfuelling commented Apr 20, 2021

I set the phoneReady to true and changed all functions to work with gcphone (in theory), but when I print out the phoneReady the value is nil even though I set the value to true in the main file

In that case you can also just remove the variable completely. I have no idea why it might be nil.

@Daandeve
Copy link
Contributor Author

I see the issue now the isHacking variable is still false after I start the tutorial, I do get teleported and I can see the messages from OMEGA but in the tutorial logic is the ìsHacking variable not true

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants