Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nemeth code translation failures #88

Open
NSoiffer opened this issue Feb 2, 2023 · 1 comment
Open

Nemeth code translation failures #88

NSoiffer opened this issue Feb 2, 2023 · 1 comment

Comments

@NSoiffer
Copy link
Contributor

NSoiffer commented Feb 2, 2023

This incorporates specific failures mentioned in #60, #61, #62, #63, and #64.

I ran MathCAT braille tests on liblouisutdml and there was only a ~15% success rate. The test results are attached.

The MathCAT tests were taken from the Nemeth "green book". That book has lots of examples which are divided up into "rules", where each rule might have several parts and each part might have several examples. The tests are numbered so that one can easily refer back to the green book. For example, "overbar_86_b_10" is a test involving overbars. That test is Rule 86, part b, example 10.

I have also attached the results of running the existing mathml_nemeth tests. These tests were done using liblouis-3.24.0 and liblouisutdml-2.11.0 compiled for windows.

The results include both the successes and failures. I wasn't able to get run_test.sh to work for me so I wrote a python script that calls file2brl with the same arguments that run_test.sh uses. The attached files are the results from that script.

Files:
nemeth_MathCAT-results.txt
mathml_nemeth-results.txt

I will submit a PR to include the MathCAT tests are part of the tests dir.

NSoiffer added a commit to NSoiffer/liblouisutdml that referenced this issue Feb 2, 2023
The MathCAT tests come from the Nemeth "green book". That book has lots of examples which are divided up into "rules", where each rule might have several parts and each part might have several examples. The tests are numbered so that one can easily refer back to the green book. For example, "overbar_86_b_10" is a test involving overbars. That test is Rule 86, part b, example 10.

There is an extremely high failure rate (~85%) as documented in liblouis#88. I think some of these might be easy to fix but others I believe require significant changes to the archetecture or significant hacks/hooks to deal with.
@hammera
Copy link
Contributor

hammera commented Jun 22, 2023

Hi Neil,

How can I possible run your Mathcat tests my feature branch?
In the tests/nemeth_mathcat directory I not see make files with integrate the test.
Possible I grab wrong commit with contains only the test data related files (xml files, expected.txt files).
I using Ubuntu based distribution, not windows.

Thanks your help,

Attila

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants