-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiaddress byte representation in Control Protocol #51
Comments
I guess it's because the daemon can use unix domain socket as well as the tcp socket. A multiaddress can represent both protocols. |
@mhchia The concern is not regarding the address of the daemon and not regarding the multiaddress itself but regarding its binary representation inside the Control Protocol between the daemon and a client |
There are multiaddrs in several other places (eg: the PeerInfo objects returned by various operations), so it felt appropriate to use the binary format. |
Also multiaddr is pretty well supported by the various languages and straightforward to implement for languages that don't have it yet (I had to implement for Gerbil, and it wasn't all that bad). |
@Nashatyrev You're right, sorry. I was writing code related to that part, so I only came up with that usage 😂 . |
Just wondering why Daemon interface operates with byte representation of multiaddress?
The interface appears pretty highlevel and the string representation would look more appropriate
The text was updated successfully, but these errors were encountered: