Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p/protocol/identify: tests fail with go1.24 #3176

Open
Jorropo opened this issue Feb 6, 2025 · 1 comment · May be fixed by #3177
Open

p2p/protocol/identify: tests fail with go1.24 #3176

Jorropo opened this issue Feb 6, 2025 · 1 comment · May be fixed by #3177

Comments

@Jorropo
Copy link
Contributor

Jorropo commented Feb 6, 2025

2025-02-06T16:01:56.108+0100	ERROR	net/identify	identify/id.go:931	12D3KooWKA7tuYB2HpxnSTQnQZ38BCBo47uEHgYFVgix6hrEXzTy received key for remote peer 12D3KooWRyKVxttvw3x1vufF38kZRC3CZgDTeFGN4hha6aL8mSPS mismatch: 12D3KooWMNguMiS45byH1KSS3BLuRmSHspPAAyYGB8nFBPofen2G
Signed record is &{0xc00011aba0 [3 1] [10 38 0 36 8 1 18 32 160 14 5 250 194 225 122 29 245 210 173 158 109 0 177 18 190 242 118 11 110 60 88 111 70 21 14 76 169 5 221 35 16 221 196 157 245 180 211 233 144 24 26 10 10 8 4 127 0 0 1 6 135 175 26 13 10 11 4 127 0 0 1 145 2 153 39 205 3] [136 206 179 191 35 3 208 203 129 71 207 227 28 114 225 185 128 8 171 145 115 240 246 221 140 94 8 12 113 31 195 93 75 161 13 111 231 124 159 196 119 84 255 47 59 126 39 227 54 122 245 221 173 224 0 197 233 14 133 212 86 147 125 3] 0xc00062d860 <nil> {{{} 1} {0 0}}}
Done sending msg
2025-02-06T16:01:57.113+0100	ERROR	net/identify	identify/id.go:801	error getting peer record from Identify message: failed to validate envelope: invalid signature or incorrect domain
--- FAIL: TestIDService (0.01s)
    --- FAIL: TestIDService/withObsAddrManager=false (0.01s)
        id_test.go:177: test peer1 has peer2 addrs correctly
        id_test.go:48: agent version mismatch <nil>
        id_test.go:189: test peer2 has peer1 addrs correctly
        id_test.go:48: agent version mismatch <nil>
        id_test.go:203: testing addrs just after disconnect
        id_test.go:213: testing addrs after TTL expiration
    --- FAIL: TestIDService/withObsAddrManager=true (0.01s)
        id_test.go:177: test peer1 has peer2 addrs correctly
        id_test.go:48: agent version mismatch <nil>
        id_test.go:189: test peer2 has peer1 addrs correctly
        id_test.go:48: agent version mismatch <nil>
        id_test.go:203: testing addrs just after disconnect
        id_test.go:213: testing addrs after TTL expiration
--- FAIL: TestLargeIdentifyMessage (0.01s)
    id_test.go:682: test peer1 has peer2 addrs correctly
    id_test.go:48: agent version mismatch <nil>
    id_test.go:696: test peer2 has peer1 addrs correctly
    id_test.go:48: agent version mismatch <nil>
    id_test.go:710: testing addrs just after disconnect
    id_test.go:720: testing addrs after TTL expiration
FAIL
FAIL	github.com/libp2p/go-libp2p/p2p/protocol/identify	12.124s
FAIL

golang/go#d79e6bec6389dfeeec84a64f283055090615bad1 is the first bad commit

Jorropo added a commit to Jorropo/go-libp2p that referenced this issue Feb 6, 2025
Jorropo added a commit to Jorropo/go-libp2p that referenced this issue Feb 6, 2025
@MarcoPolo
Copy link
Collaborator

The issue here is that debug.ReadBuildInfo() now returns a value in this test context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants