-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swarm: Rename NetworkBehaviourAction
to ToSwarm
#3123
Comments
I am in favor of a rename for the sake of consistency. I don't have a strong opinion on the name. |
Hmm, I just realised that |
Given that the |
It even says in the documentation:
|
Based on out-of-band discussion, updating labels here. Please comment in case you think this is not appropriate. |
Resolves libp2p#3123. Pull-Request: libp2p#3658.
Description
Similar to #2854, what do people think of renaming
NetworkBehaviourAction
toToSwarm
?Motivation
Consistent naming of messages between our "actors".
Current Implementation
The current naming is very inconsistent which makes things hard to understand.
Are you planning to do it yourself in a pull request?
Maybe.
The text was updated successfully, but these errors were encountered: