swarm: Rename NetworkBehaviourAction to ToSwarm

[thomaseizinger]

Description

Similar to #2854, what do people think of renaming NetworkBehaviourAction to ToSwarm?

Motivation

Consistent naming of messages between our "actors".

Current Implementation

The current naming is very inconsistent which makes things hard to understand.

Are you planning to do it yourself in a pull request?

Maybe.

[mxinden]

I am in favor of a rename for the sake of consistency. I don't have a strong opinion on the name. ToSwarm sounds good to me.

[thomaseizinger]

Hmm, I just realised that ToSwarm doesn't quite work because we also have a NotifyHandler variant in there.

[mxinden]

Given that the NotifyHandler event is passed through the Swarm one could argue that ToSwarm is still a valid name.

[thomaseizinger]

It even says in the documentation:

Instructs the Swarm to send an event to the handler dedicated to a connection with a peer.

[mxinden]

Based on out-of-band discussion, updating labels here. Please comment in case you think this is not appropriate.

[thomaseizinger]

If we end up succeeding with #3591, the 2nd type parameter will go away through that, thus, I don't think it is worth going into the direction of #3273 but instead do a simple rename with a type alias to retain backwards-compatibility.

Based on that, I think this is difficulty:easy.