Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retroarch lost its audio on pipewire #17442

Closed
1 of 2 tasks
1985a opened this issue Jan 20, 2025 · 10 comments
Closed
1 of 2 tasks

Retroarch lost its audio on pipewire #17442

1985a opened this issue Jan 20, 2025 · 10 comments

Comments

@1985a
Copy link

1985a commented Jan 20, 2025

Is there an existing issue for this?

  • This is a bug in RetroArch frontend
  • I have searched the existing issues

Description

I'm on archlinux, using pipewire audio, as well as menu sound activated. This is the easiest way to notice the issue.
if you load a core wait for any sound, then go back to the retroarch's menu, the sound will gone, and the core sound as well.

then, if you compile this commit, fb338b9 the program works as expected.

I don't know anything about programming, but I did search for the bug with git bisect help, and it told me the bug is here 1d6badb

Expected behavior

No response

Steps to reproduce the bug

load retroarch
load a game
wait for any sound
then go back to retroarchs menu
then go back to the game

Version/Commit

retrorach last commit

Bisect Results

1d6badb

Present in the nightly version

Yes, this is reproduced in the nightly build

Platform & operating system

Archlinux

Affected Cores

Any core

Environment information

No response

Relevant log output

@gouchi
Copy link
Member

gouchi commented Jan 20, 2025

ping @viachaslavic

@viachaslavic
Copy link
Contributor

@1985a Thanks for reporting! Could you please provide the RetroArch logs?

@1985a
Copy link
Author

1985a commented Jan 20, 2025

I uploaded the files, the latest commit, and the good for me.
I saw a message saying I needed to increase the latency to fix the problem, but in the good commit, it works fine.
On my retroarch config, I set the latency to 32ms. My system works with low-latency audio.

retroarchlogbad.log
retroarchloggood.log

@viachaslavic
Copy link
Contributor

Indeed, the early version of the driver was implemented only in non-blocking mode. Unfortunately, I can't reproduce this issue yet.
Could you please try to compile with a few potential fixes ?

@1985a
Copy link
Author

1985a commented Jan 21, 2025

I did and the issue persists.

On the console, it throws these errors

*** pw_stream_destroy called from wrong context, check thread and locking: Operation not permitted
*** impl_ext_end_proxy called from wrong context, check thread and locking: Operation not permitted
'this->recurse > 0' failed at ../pipewire/src/pipewire/thread-loop.c:62 do_unlock()
'this->recurse > 0' failed at ../pipewire/src/pipewire/thread-loop.c:62 do_unlock()

I tried to increase the latency, but the issues still there
It only works for me with the commit I did before.

@1985a
Copy link
Author

1985a commented Jan 21, 2025

Indeed, the early version of the driver was implemented only in non-blocking mode. Unfortunately, I can't reproduce this issue yet. Could you please try to compile with a few potential fixes ?

if you want, I can provide my pipewire config and my retroarch config as well.

@viachaslavic
Copy link
Contributor

viachaslavic commented Jan 21, 2025

*** pw_stream_destroy called from wrong context, check thread and locking: Operation not permitted
*** impl_ext_end_proxy called from wrong context, check thread and locking: Operation not permitted
'this->recurse > 0' failed at ../pipewire/src/pipewire/thread-loop.c:62 do_unlock()
'this->recurse > 0' failed at ../pipewire/src/pipewire/thread-loop.c:62 do_unlock()

I fixed this, but I doubt that this will somehow solve the issue.

@gouchi
Copy link
Member

gouchi commented Jan 21, 2025

@1985a Do you reproduce the issue with another audio driver ? Because the issue might coming from menu sound enabled.

Thank you.

@1985a
Copy link
Author

1985a commented Jan 21, 2025

The problem has gone with the last commit from your repository viachaslavic@f84f829. Also, I tested with the pulse driver, and the problem didn't come up.

EDIT: also test with the master repository and the issue is not more.
I think this can be closed now.

@gouchi
Copy link
Member

gouchi commented Jan 22, 2025

@1985a Please close this issue as it is fixed with nightly.

Thank you.

@1985a 1985a closed this as completed Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants