Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compressed Formats Writing Temporary Files to Disk #122

Closed
0x90shell opened this issue Jan 27, 2022 · 1 comment · Fixed by #123
Closed

Compressed Formats Writing Temporary Files to Disk #122

0x90shell opened this issue Jan 27, 2022 · 1 comment · Fixed by #123

Comments

@0x90shell
Copy link

0x90shell commented Jan 27, 2022

Currently, compressed formats will have temporary files extracted to disk, even if the load in memory core settings are used. This is due to the core setting "need_fullpath" being set to "true."

In June 2021, RA 1.9.5 added per file extension "need_fullpath" overrides to the API. If there is a reason this cannot be set to false for specific files (bin/cue, chd, etc), the "RETRO_ENVIRONMENT_SET_CONTENT_INFO_OVERRIDE" function can be utilized. Additionally, the "RETRO_ENVIRONMENT_GET_GAME_INFO_EXT" function can be utilized to obtain the metadata for compressed formats to find the underlying ROM extension.

By setting "need_fullpath" to false by default, compressed ROM files can be loaded directly into memory rather than extracting temporary copies to disk. This also allows soft-patching and run ahead to be utilized more efficiently. For reference, this functionality was added in the 2 other libretro PCE cores already.

References:
libretro/RetroArch#12473
libretro/beetle-pce-fast-libretro#189
libretro/beetle-pce-libretro#26
https://www.libretro.com/index.php/retroarch-1-9-5-released/

@negativeExponent
Copy link
Contributor

this should be fixed when PR gets merged....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants