Reverts baked-in NstDatabase.xml #28
Conversation
With rdanbrook's blessing Fixes libretro#5 Fixes libretro#19 Fixes libretro#25
|
I don't want this to be outright removed. I'd prefer if it remains baked-in, HOWEVER, IF some user wants to override it with a supplied config file like this, he can do so as well. I'm fine with that. The vast majority of our userbase might never have this file supplied, so it's absolutely bad to remove this and I consider it a regression. As long as what I propose above can be achieved, then I'm fine with how things go, but outright removal of a baked-in NstDatabase.xml is something I completely oppose and will veto. |
|
Well, none of the ROMs I have don't work without the database. The region and controls can be configured in the UI, so really the only thing left is mappers. I considered adding an option for mappers (like Gearboy does) when I added the configurable controls, but the quantity of mappers makes that extremely difficult with little benefit. Maybe it could be added just for mappers known not to be detected correctly (if any). |
|
If I may, could it be made a core option that defaults to using the baked-in database, unless the user specifies that they want to use an external file or no database at all? Something like: "Use Baked-in NstDatabase.xml file" -> ON (Default); OFF (looks for the NstDatabase.xml file in the system folder and does not use the internal database at all) The advantage of doing it this way is that it is possible to customize this to each user's preference. You can save a per-game core option file and micromanage this for the sake of having the best compatibility, while preserving the default approach as it is currently implemented. |
|
yeah I'd be fine with a core option like that, and to leave it enabled by default so it uses the baked NstDatabase.xml, and by changing the core option, it will look for a user supplied file instead. |
|
I see that this PR has been closed for now. Is the possibility of a core option that allows users to enable/disable the baked-in Database still being considered? |
|
This pre-built core contains all Nestopia updates and this closed PR, Santa Claus is at it again! |
With rdanbrook's blessing
Fixes #5
Fixes #19
Fixes #25