Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move core-generated files (config + saves) to frontend-defined save directory - 2nd attempt #60

Merged
merged 1 commit into from
Apr 21, 2018

Conversation

jdgleaver
Copy link
Contributor

Again, really sorry for making a hash of this the first time...

@inactive123
Copy link
Contributor

No problem, mistakes happen.

@inactive123 inactive123 merged commit be9ffe2 into libretro:master Apr 21, 2018
@thatman84
Copy link

Core is not loading the content downloader Quake (Shareware) on Android. Confirmed with Bparker

Updated core and content and is working on Windows.

Sorry for the lack of information. Just a quick heads up as in the middle of something

@jdgleaver
Copy link
Contributor Author

Thanks for the warning! I can confirm this.

There is definitely something strange going on here...

  • Under both Linux and Windows, the updated core loads all content correctly.

  • Under Android, only the full version of the base game + the 2 official expansions work correctly. Attempting to run any unofficial expansion or mod causes the base game to load. It is as though the internal '-game' command line option is being ignored completely. And as stated, the 'content downloader' shareware version fails to load at all.

thatman84 - do you happen to know if the last version of the Android core was able to load 'unofficial' content correctly? I know this used to work, but the previous version of the core I was using was from before the buildbot switched to clang (and before the Android jni makefiles were updated) - i.e. I don't know if this content loading problem was an existing issue caused by other factors...

I can't do anything today (I'm not at home and don't have my stuff...), but I'll see if I can try to debug this next week...

@thatman84
Copy link

I will check tonight when im home.

I have the previous verstion on my shield tv most likely. Will test and grab the build number. I only updated the core when i started the forum topic not sure if that was before or after the clang thing

@thatman84
Copy link

thatman84 commented Apr 22, 2018

Ok the core the only other core version for Android I can test is in this image

retroarch_20180422_194742

Shield TV
Killer Quake Mod tested and Quake(Shareware) from content downloader.

Workig as expected.

Hope that helps

@jdgleaver jdgleaver deleted the save-relocation-fix branch April 23, 2018 08:50
@jdgleaver
Copy link
Contributor Author

Thanks for this. The working core you have is from the commit before the build system changed. This makes me suspicious... I shall investigate!

@jdgleaver
Copy link
Contributor Author

An update - I forgot to mention that this is now being tracked as issue #61.

TLDR version: I have identified the bug and found a fix, but I haven't a clue why the bug exists. I don't want to submit the fix if I don't know why it works, so I'm hoping someone else can help with the investigation...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants