-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No sound played when a game starts #890
Comments
Do we really want this in the app? I can understand the reason of the bell sound on a desktop, since the user might be looking at another tab or application. But in the context of the application it is not really possible right now do to sth else while waiting for a game so the bell sounds redundant to me. |
I saw this on the lichess beta group https://lichess.org/forum/team-lichess-beta-testers/mobile-app-alpha?page=11
So basically, instead of looking at other tabs, people might be looking at real life while waiting :D Once we support tournaments I think this becomes even more important, waiting for the next tournament game (in my experience) can sometimes take much longer than waiting in the normal game queue. |
Right, I agree it makes sense to add it :) |
What is the problem?
Both the old app and lichess.org play the "bell" sound when a new game starts (e.g. after finding a game via the game matrix, or when your next pairing in a tournament is found). This is currently missing from the new app.
Steps to reproduce the bug
App version
0.9.3
Device Info
Pixel 4a, Android
Additional information
Note that the bell sound is already played when a game is finished.
The correct place to implement this is probably somewhere in
game_controller.dart
? We could play the sound when receiving a new game withgame.status == started
andgame.steps.length == 0
.The text was updated successfully, but these errors were encountered: