Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: adding Bootstrap 4 #57

Open
zoltan-nz opened this issue Jan 22, 2018 · 6 comments
Open

New feature: adding Bootstrap 4 #57

zoltan-nz opened this issue Jan 22, 2018 · 6 comments

Comments

@zoltan-nz
Copy link
Contributor

I think, there could be a config option which would determine which Bootstrap version should be wrapped in vendor.js.

Suggested config property:

bootstrapVersion: 4

In ember-cli-bootstrap-sassy v1.0.0 can be Bootstrap v4 the default.

@belgoros
Copy link

belgoros commented Feb 9, 2018

👍 That would be great to have Bootstrap 4 implemented with the same success: no headaches with JS components, just use Bootstrap CSS classes (no need to use special tags s it is the case with ember-bootstrap or ember-cli-foundation-sass add-ons. Waiting with impatience :). Unfortunately, there are some new dependencies introduced with BS4 (popper.js) and no more glyphicons available.

@yankeeinlondon
Copy link
Member

I think there are enough differences in philosophy as well as structure to just have a separate repo for this. I created a BS4 addon a year ago or so called ui-bootstrap that did this. I have stopped development on that but I just did a search on emberaddons and seems there's a recently updated ember-cli-bootstrap-4 out there.

@yankeeinlondon
Copy link
Member

If anyone is interested in taking over as maintainer for ui-bootstrap or ember-cli-bootstrap-sassy I'm happy to pass the responsibility over. I feel my current time on Ember is too limited to serve it full justice.

@belgoros
Copy link

belgoros commented Feb 11, 2018

Thank you, Ken for the link. Unfortunately it even fails to boot.

@yankeeinlondon
Copy link
Member

Bummer. Well my ui-bootstrap should still work if you need BS4 in a hurry.

@belgoros
Copy link

belgoros commented Feb 12, 2018

Thank you, Ken. They've fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants