Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase code coverage to an acceptable level #26

Closed
fmorency opened this issue Mar 25, 2024 · 3 comments
Closed

Increase code coverage to an acceptable level #26

fmorency opened this issue Mar 25, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request test

Comments

@fmorency
Copy link
Collaborator

fmorency commented Mar 25, 2024

Code coverage currently sits at 35.7%, which is low.

Edit: poa and tokenfactory modules coverage sit at 53.9% and 39.9% respectively. See strangelove-ventures/poa#148 and strangelove-ventures/tokenfactory#5

@fmorency fmorency added enhancement New feature or request test labels Mar 25, 2024
@fmorency
Copy link
Collaborator Author

fmorency commented Apr 17, 2024

The interchaintest tests are calling the manifestd binary a lot. This is currently not tracked in the coverage report.

Idea: Instrument manifestd with coverage support and retrieve the coverage data. Merge this coverage data with unit test coverage data.

It works when using bare Docker but not via interchaintest

I'm not sure how to continue.

The problem is that the retrieved coverage data is empty.

I think I need a mechanism to be able to retrieve the coverage data from every temporary container spawned by interchaintest and not only from the "main" test container.

@fmorency
Copy link
Collaborator Author

See #45. Should improve the coverage by a lot.

@fmorency
Copy link
Collaborator Author

#45 bumped the coverage to 60%. There is room for improvement, but we're off to a good start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test
Projects
None yet
Development

No branches or pull requests

3 participants