-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading SentenceTransformer Model and _load_sbert_model
in ColBERT class
#64
Comments
Hello, Indeed, breaking changes were introduced in this commit of ST, hence why we fixed the version of sentence-transformers to the last version before 3.1 (sentence-transformers == 3.0.1). The fix is indeed what you suggested and during my preliminary tests, it seemed to work fine, but I wanted to make sure there was no regression before doing a PR for the fix and bump the version of ST. I might do the PR in the next days if it becomes needed. |
Hello again, I fixed the issue in #65 and now the training with the model from Ordalie works fine with ST 3.2.0! |
Hey Great, It's also working on my setup. I will try to continue digging into the repo. (I am specially interested in training/fine-tuning french retrieval models) Benoît HARDIER |
Cool! |
Closing since the PR has been merged. |
Hey, thanks for your work.
I am trying to finetuned a model based on
OrdalieTech/Solon-embeddings-base-0.1
.like that:
Unfortunatly, it seems that the
_load_sbert_model
should output bothmodules
andmodule_kwargs
(The SentenceTranformer doc seems wrong) .I am not sure if it's related to the SentenceTransformer version but I am using the last one 3.2.0
I finally succeed to load solon changing the
_load_sbert_model
incolbert.py
It should be modified:
pylate/pylate/models/colbert.py
Line 1153 in ddaf8f8
pylate/pylate/models/colbert.py
Lines 1194 to 1199 in ddaf8f8
Let me know, if I am doing something wrong or if my issue is useful.
Benoît HARDIER
The text was updated successfully, but these errors were encountered: