From 39de24974bbe4124d52bc77f84c0f70b4db8a087 Mon Sep 17 00:00:00 2001 From: eliranb Date: Thu, 20 Jun 2024 12:59:40 +0300 Subject: [PATCH 1/2] expose init container tag as param and point it to lightruncom/prod-base repo --- .github/workflows/init_container.yaml | 3 +++ lightrun-init-agent/Dockerfile | 3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/init_container.yaml b/.github/workflows/init_container.yaml index cf79e92..819bd2d 100644 --- a/.github/workflows/init_container.yaml +++ b/.github/workflows/init_container.yaml @@ -111,6 +111,8 @@ jobs: - name: Build and push ${{ matrix.agents.name }} container uses: docker/build-push-action@v4 + env: + base_image_tag: alpine-3.20.0 with: context: . file: ./lightrun-init-agent/Dockerfile @@ -119,6 +121,7 @@ jobs: tags: ${{steps.set_docker_tags.outputs.DOCKER_TAGS}} build-args: | FILE=${{ matrix.agents.file }} + base_image_tag=$base_image_tag - name: Slack Notification if: always() diff --git a/lightrun-init-agent/Dockerfile b/lightrun-init-agent/Dockerfile index 4a06a06..2c98c86 100644 --- a/lightrun-init-agent/Dockerfile +++ b/lightrun-init-agent/Dockerfile @@ -1,5 +1,6 @@ -FROM alpine:latest +ARG base_image_tag=alpine-3.20.0 +FROM lightruncom/prod-base:${base_image_tag} ARG FILE COPY lightrun-init-agent/$FILE /tmp/$FILE From e8d1585b1617f7bd8820c5945e4316f87f11de54 Mon Sep 17 00:00:00 2001 From: eliranb Date: Sun, 23 Jun 2024 11:21:41 +0300 Subject: [PATCH 2/2] try using env inside a job --- .github/workflows/init_container.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/init_container.yaml b/.github/workflows/init_container.yaml index 819bd2d..87320e3 100644 --- a/.github/workflows/init_container.yaml +++ b/.github/workflows/init_container.yaml @@ -40,6 +40,8 @@ jobs: ] runs-on: ubuntu-latest name: Build and push Docker image + env: + base_image_tag: alpine-3.20.0 steps: - name: Set release tag shell: bash @@ -111,8 +113,6 @@ jobs: - name: Build and push ${{ matrix.agents.name }} container uses: docker/build-push-action@v4 - env: - base_image_tag: alpine-3.20.0 with: context: . file: ./lightrun-init-agent/Dockerfile @@ -121,7 +121,7 @@ jobs: tags: ${{steps.set_docker_tags.outputs.DOCKER_TAGS}} build-args: | FILE=${{ matrix.agents.file }} - base_image_tag=$base_image_tag + base_image_tag=${{ env.base_image_tag }} - name: Slack Notification if: always()