Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't work overriding for symfony 4.3 templates/bundles #201

Closed
Pasuvan opened this issue Oct 4, 2019 · 2 comments · May be fixed by #202
Closed

Can't work overriding for symfony 4.3 templates/bundles #201

Pasuvan opened this issue Oct 4, 2019 · 2 comments · May be fixed by #202

Comments

@Pasuvan
Copy link

Pasuvan commented Oct 4, 2019

Hi, already I put the question for Symfony portal, Please can you check that below link
symfony/symfony#33845
@dpmR
Copy link

dpmR commented Oct 15, 2019 •
edited
Loading

I am facing the same problem. After digging into the code I think I found the root of the problem.

LiipThemeBundle/Locator/FileLocator.php

Line 134 in 3623948

if ('@' === $name[0]) {

=> $name contains 'views/@BundleName' instead of '@Bundle' so it does not jump into locateBundleResource

Also in

LiipThemeBundle/Locator/FileLocator.php

Line 167 in 3623948

$bundleName = substr($name, 1);
the 'views/' part needs to be removed.

With this changes made I can set a new path_pattern which then works:

liip_theme:
  ...
  path_patterns:
    app_resource:
      - '%kernel.project_dir%/templates/themes/%%current_theme%%/%%template%%'
      - '%kernel.project_dir%/templates/themes/default/%%template%%'
    bundle_resource:
      - '%kernel.project_dir%/templates/themes/%%current_theme%%/bundles/%%bundle_name%%/%%template%%'
      - '%kernel.project_dir%/templates/themes/default/bundles/%%bundle_name%%/%%template%%'

@dpmR dpmR mentioned this issue Oct 15, 2019
Open
@Pasuvan
Copy link
Author

Pasuvan commented Oct 16, 2019

Thanks @dpmR it's worked

@Pasuvan Pasuvan closed this as completed Oct 16, 2019
@Pasuvan Pasuvan mentioned this issue Oct 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Fix bundle template override in Symfony 4.3 dpmR/LiipThemeBundle
2 participants
@dpmR @Pasuvan