You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It feels inconsistent to me that a locked disk will abort the command, but a non-existing disk is simply skipped:
limactl disk rm foo bar
If foo doesn't exist, bar will still be deleted. But if foo exists and is locked, then bar will not be deleted (and there is no message to the effect that additional disks have been skipped due to the error).
I think a locked disk should be logged as an error, but additional disks should still be processed.
And then I wonder if failures of deleteDisk() should be treated the same way too: log an error, but continue to attempt deleting the remaining disks?
Of course the command must exit with a non-zero status code if any disk couldn't be deleted. I'm not sure how non-existing disks should be treated: should they also cause a non-zero error?
It feels inconsistent to me that a locked disk will abort the command, but a non-existing disk is simply skipped:
If
foo
doesn't exist,bar
will still be deleted. But iffoo
exists and is locked, thenbar
will not be deleted (and there is no message to the effect that additional disks have been skipped due to the error).I think a locked disk should be logged as an error, but additional disks should still be processed.
And then I wonder if failures of
deleteDisk()
should be treated the same way too: log an error, but continue to attempt deleting the remaining disks?Of course the command must exit with a non-zero status code if any disk couldn't be deleted. I'm not sure how non-existing disks should be treated: should they also cause a non-zero error?
@AkihiroSuda WDYT?
Originally posted by @jandubois in #1065 (comment)
The text was updated successfully, but these errors were encountered: