Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GROOMING] Fix library security warning #191

Open
2 tasks
renaudboyer opened this issue Apr 27, 2021 · 1 comment
Open
2 tasks

[GROOMING] Fix library security warning #191

renaudboyer opened this issue Apr 27, 2021 · 1 comment
Assignees

Comments

@renaudboyer
Copy link
Contributor

renaudboyer commented Apr 27, 2021

Update outdated libraries according to the security report.

https://github.com/OpenPaaS-Suite/esn-frontend-common-libs/security/dependabot

CRITERIA:

  • List of libraries that can be updated
  • Breaking changes of libraries upgrades.
@renaudboyer renaudboyer changed the title Fix library security warning [GROOMING] Fix library security warning Apr 27, 2021
@rezk2ll rezk2ll self-assigned this Apr 29, 2021
@rezk2ll
Copy link
Member

rezk2ll commented May 3, 2021

what can't be upgraded?

  • lodash ( the version we have is 7 years old )
  • angular
    image

dependencies that can be upgraded without problems:

DomPurify ( used in the esnDomPurify filter )

used in

  • esn-frontend-inbox ( message-body-html.pug template )
  • version in common-libs: 1.0.9
  • version in esn-frontend-inbox ( overrided version ): ~2.2.0

can be upgraded to ~2.2.0

jekyll

used in gruntfile to validate bootstrap html documentation

kramdown

Jekyll dependency and not specified in the package files, upgrading Jekyll upgrades automatically this dependency

ffi

ruby package, only present in lockfile and not in package files

bower 1.2.8

used in angular-recaptcha as a dev dependency

semver

used in Chart.js gulpfile task just to bump chart.js version: dev dependency

bootstrap

we used static bootstrap package files for version 3.3.7, upgrading the package.json means nothing, to upgrade we need to change the files in src/frontend/components/bootstrap. also, no problems going from 3.3.7 to 3.4.1

jquery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants