Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU] deleted accounts still are proposed by Tmail-web autocompletion #30

Closed
quantranhong1999 opened this issue Jan 16, 2025 · 5 comments · Fixed by #31
Closed

[MU] deleted accounts still are proposed by Tmail-web autocompletion #30

quantranhong1999 opened this issue Jan 16, 2025 · 5 comments · Fixed by #31
Assignees
Labels
bug Something isn't working

Comments

@quantranhong1999
Copy link
Member

quantranhong1999 commented Jan 16, 2025

When we delete a user entry in LDAP (e.g. a part of user renaming, or even the guy left the organization), the deleted addresses still are proposed by Tmail-web autocompletion.

Indeed, the LSC contact sync job does not delete the domain contact following LDAP entry deletion https://github.com/linagora/tmail-lsc/blob/main/src/main/java/org/lsc/plugins/connectors/james/TMailContactDstService.java#L82

We should handle domain contact deletion

DoD: integration test

And config + image adapted on MU

cc @guimard

@quantranhong1999
Copy link
Member Author

#31

@quantranhong1999
Copy link
Member Author

Notes for MU deployment:

  • build and publish the latest LSC image

  • add --clean all option into LSC command so LSC can perform the delete operation

  • enable delete operation for LSC contact sync job in lsc.xml
    For other deployments than MU, no harm because the delete operation is disabled by default in lsc.xml.

  • Configure system env DOMAIN_LIST_TO_SYNCHRONIZE for MU contact sync jobs (otherwise the govmu.org contact job would delete mailing list contacts and vice versa).
    For example:

    • for govmu.org job, set /usr/bin/docker run --rm --name tmail-lsc-contacts -e DOMAIN_LIST_TO_SYNCHRONIZE="govmu.org".

    • for lists.govmu.org job, set /usr/bin/docker run --rm --name tmail-lsc-contacts-ml -e DOMAIN_LIST_TO_SYNCHRONIZE="lists.govmu.org".

@quantranhong1999
Copy link
Member Author

Deployed on MU. Old names contacts were deleted well while keeping the govmu.org / lists.govmu.org contacts correct.

@quantranhong1999
Copy link
Member Author

Noise/benign error logs though e.g. when running lists.govmu.org job:

Jan 20 03:11:32 - ERROR - Error while synchronizing ID dbaumee@govmu.org: java.lang.Exception: Technical problem while applying modifications to destination service
# Mon Jan 20 03:11:32 UTC 2025
dn: dbaumee@govmu.org
changetype: delete

Jan 20 03:11:32 - ERROR - All entries: 9549, to modify entries: 9456, successfully modified entries: 1, errors: 9455

Likely LSC tried to fetch all the domain contacts as the current list pivots (which contains govmu.org contacts and does not exist on LDAP baseDN) -> LSC determines a delete operation for the contact, but got rejected by DOMAIN_LIST_TO_SYNCHRONIZE filtering and generate the error logs.

I will try to find a way to silent those benign error logs.

@quantranhong1999
Copy link
Member Author

I will try to find a way to silent those benign error logs.

#32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant